Bug 159587

Summary:	OpenPGP: don't show confirmation dialog when Certificate Manager was launched successfully
Product:	LibreOffice	Reporter:	steve <lo>
Component:	LibreOffice	Assignee:	Not Assigned <libreoffice-bugs>
Status:	NEW ---
Severity:	normal	CC:	kolAflash, sierkb, telesto
Priority:	medium
Version:	24.8.0.0 alpha0+
Hardware:	All
OS:	macOS (All)
See Also:	https://bugs.documentfoundation.org/show_bug.cgi?id=159307 https://bugs.documentfoundation.org/show_bug.cgi?id=156979
Whiteboard:
Crash report or crash signature:		Regression By:
Bug Depends on:
Bug Blocks:	158839

Description steve 2024-02-06 05:22:57 UTC

Description:
OpenPGP: don't show confirmation dialog when Certificate Manager was launched successfully

Steps to Reproduce:
1. Create a writer document, type anything and save
2. open File > Digital Signature > Digital Signatures > Start Certificate Manager

Actual Results:
When GPG Suite is installed on macOS, GPG Keychain opens (expected). LibreOffice shows a confirmation dialog stating:
"Information: You have opened the certificate manager at
/Applications/GPG Keychain.app" OK

Expected Results:
That dialog has no value. The certificate manager will open above existing open windows so always be visible to the user. There really is no need to bother the user to click OK for an action they can visually see in front of themselves.

Showing a dialog is a great idea, but only when there is a problem and things need fixing. WHen things work as expected I'd prefer to not complicate user workflows unnecessarily.


Reproducible: Always


User Profile Reset: No

Additional Info:
Version: 24.8.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 6b6849107562b258aa8858e94ff3c07160f07062
CPU threads: 8; OS: macOS 13.6.4; UI render: Skia/Metal; VCL: osx
Locale: en-US (en_DE.UTF-8); UI: en-US
Calc: threaded

Comment 1 Sierk Bornemann 2024-02-06 13:50:08 UTC

I confirm the issue in question and side with steve.

See also my comment
https://bugs.documentfoundation.org/show_bug.cgi?id=147291#c25

Version: 24.8.0.0.alpha0+ (AARCH64) / LibreOffice Community
Build ID: 6b6849107562b258aa8858e94ff3c07160f07062
CPU threads: 10; OS: macOS 14.3; UI render: Skia/Metal; VCL: osx
Locale: de-DE (de_DE.UTF-8); UI: de-DE
Calc: threaded

Comment 2 kolAflash 2024-05-03 13:23:31 UTC

Confirming on Debian-12 + KDE-Plasma where Kleopatra is being opened.

The dialog window was added in this commit.
https://git.libreoffice.org/core/+/92b6ffcd9f687cc54a0fc3801ca85c7e4d77512f%5E%21/#F6



(In reply to steve from comment #0)
> [...]
> Expected Results:
> [...]
> Showing a dialog is a great idea, but only when there is a problem and
> things need fixing. When things work as expected I'd prefer to not
> complicate user workflows unnecessarily.

At the moment there seems to be no additional dialog if starting the Certificate Manager fails!

Actually when starting the Certificate Manager fails, the standard dialog comes up anyway. Telling you
  You have opened the certificate manager at ...
Although no certificate manager was started.


TESTING THE CERTIFICATE MANAGER FAILING TO START:

It looks like, if a Certificate Manager is available, it gets automatically set in
  Tools > Options > LibreOffice > Security
as "Certificate Manager". For Debian-12 with KDE-Plasma that's /usr/bin/kleopatra
But if you uninstall the certificate manager afterwards, LibreOffice keeps that setting. And if you click on "Certificate Manager" it unsuccessfully tries to start the configured Certificate Manager.

see also: related bug 156979
certificate manager path reset to default when certificate manager opened



So I'd say, first an error message must be provided in case starting the certificate manager fails.

And the field in the Options should behave in a more intuitive way. I think the best choice is not to permanently set a "Certificate Manager" automatically. But to use the automatic choice only for that very moment (not storing it).